LPS-55718

[drewbrokke]

This is an update for LPS-55718.

@pei-jung, @JorgeFerrer, @natecavanaugh

[liferay-continuous-integration]

All tests PASSED!

Build Time: 35 minutes 39 seconds

See the following links for more information.

• https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest(master)/68/
• https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-githubpost-start(master)/68/
• https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/68/
• https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-plugins(master)/50/
• https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-backend(master)/50/
• https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-githubpost-stop(master)/67/

[ealonso]

Just started reviewing :)

Sent from GH.

[ealonso]

Hi @drewbrokke,

I've sent a few commits to Brian: see brianchandotcom#27296

A few things about the pull:

1. About the last commit "ant format-source": it is better to merge it with each file, because if you put it at the end it is more difficult to review the pull commit by commit.
2. When we make a commit like "Makes methods public, no logic changes" we should do an "ant format-source". This is the purpose for this commit, so us to make easier to understand the next commit.
3. Regarding ActionCommad, we should use it only in the necessary cases, for example, if you have an Action in a separate file you can create an ActionCommad with this action. In our case, for Delete and Update methods, it is really rare create two different classes and split the methods, IMHO we should put it on the portlet class.

Could you make those changes and resend?

Thanks!!!