From 0b41ac666068072b73080309db764969f7c21c88 Mon Sep 17 00:00:00 2001 From: Evyatar Date: Sat, 23 May 2020 01:28:11 +0300 Subject: [PATCH] breaking: throwError actually throws (#149) --- packages/vest/dist/vest.js | 32 +++++++++++------------ packages/vest/dist/vest.min.js | 2 +- packages/vest/src/lib/throwError/index.js | 6 +---- packages/vest/src/lib/throwError/spec.js | 23 +++++----------- 4 files changed, 25 insertions(+), 38 deletions(-) diff --git a/packages/vest/dist/vest.js b/packages/vest/dist/vest.js index 8f9b79a03..8aee43d81 100644 --- a/packages/vest/dist/vest.js +++ b/packages/vest/dist/vest.js @@ -11,19 +11,19 @@ arguments.length,d=Array(2b},longerThanOrEquals:function(a,b){return a.length>=b},shorterThan:function(a,b){return a.lengtht.length)&&(n=t.length);for(var e=0,r=Array(n);eNumber(n)}function d(t,n){return s(t)&&s(n)&&Number(t)>=Number(n)}function p(t,n){return s(t)&&s(n)&&Number(t)n},longerThanOrEquals:function(t,n){return t.length>=n},shorterThan:function(t,n){return t.lengtht.length)&&(n=t.length);for(var e=0,r=Array(n);eNumber(n)}function d(t,n){return s(t)&&s(n)&&Number(t)>=Number(n)}function p(t,n){return s(t)&&s(n)&&Number(t)n},longerThanOrEquals:function(t,n){return t.length>=n},shorterThan:function(t,n){return t.length { - const error = new type(`[Vest]: ${message}`); - setTimeout(() => { - throw error; - }); - return error; + throw new type(`[Vest]: ${message}`); }; export default throwError; diff --git a/packages/vest/src/lib/throwError/spec.js b/packages/vest/src/lib/throwError/spec.js index a00217d35..6a7e00431 100644 --- a/packages/vest/src/lib/throwError/spec.js +++ b/packages/vest/src/lib/throwError/spec.js @@ -1,22 +1,13 @@ -const faker = require("faker"); -const throwError = require("."); +const throwError = require('.'); -describe("throwError", () => { - let _setTimeout, errorString; +const message = 'message string'; - beforeEach(() => { - errorString = faker.lorem.sentence(); - _setTimeout = global.setTimeout; - global.setTimeout = jest.fn((cb) => cb()); +describe('throwError', () => { + it('Should throw with passed message', () => { + expect(() => throwError(message)).toThrow(`[Vest]: ${message}`); }); - afterEach(() => { - global.setTimeout = _setTimeout; - }); - - it("Should throw a timed out error", () => { - expect(setTimeout).toHaveBeenCalledTimes(0); - expect(() => throwError(errorString)).toThrow(); - expect(setTimeout).toHaveBeenCalledTimes(1); + it('Should throw provided error type', () => { + expect(() => throwError(message, TypeError)).toThrow(TypeError); }); });