New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word wrapping issue when viewing blame annotations #149

Closed
fgallardograzio opened this Issue Sep 20, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@fgallardograzio

fgallardograzio commented Sep 20, 2017

Word wrapping breaks the blame layout. Please see the attached screenshot.

I think the appropriate behaviour would be to wrap the lines on the right hand side of the "blame panel", after the heatmap.

If this is technically problematic to do, then I'd rather have word wrapping automatically disabled when blaming a file.

image

Thanks!


  • GitLens Version: 5.1.0
  • VSCode Version: 1.16.1
  • OS Version: Linux Mint 18
@eamodio

This comment has been minimized.

Owner

eamodio commented Sep 20, 2017

@fgallardograzio While I would love to fix this, unfortunately the only way I can provide the blame annotations (via the vscode api) doesn't allow for something like this. Hopefully vscode will ultimately provide a true gutter api and the crazy hacks that GitLens has to do could be a thing of the past :)

@eamodio eamodio closed this Sep 20, 2017

@fgallardograzio

This comment has been minimized.

fgallardograzio commented Sep 20, 2017

@eamodio what about having the extension disable word wrapping automatically when blaming a file?

@eamodio

This comment has been minimized.

Owner

eamodio commented Sep 20, 2017

Good idea, but I've gone down that path with toggling on/off visible whitespace (used to be required to the annotations to render properly) and it was fraught with issues and caused a noticeable delay in triggering the annotations. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment