New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GitLens to "Source Control" activity #213

Closed
ADTC opened this Issue Nov 27, 2017 · 11 comments

Comments

Projects
None yet
4 participants
@ADTC

ADTC commented Nov 27, 2017

Right now, GitLens is in the Explorer panel (Ctrl-Shift-E). I would like it to be in the Source Control panel (Ctrl-Shift-G). It makes more sense to be there, and I want the Explorer panel to just be focused on exploring (I even disabled the Open Editors view).

I don't know if VSCode API allows this. I hope so... (Edit: I think it should be possible: https://code.visualstudio.com/docs/extensionAPI/api-scm )

@eamodio

This comment has been minimized.

Owner

eamodio commented Nov 27, 2017

Sadly this isn't yet possible, see Microsoft/vscode#28662. Although once it is possible you bet there will be an option at least to put it there -- because that's exactly where I want it too :)

But until that changes there is nothing GitLens can do, so I'm going to close this until that changes.

@ADTC

This comment has been minimized.

ADTC commented Nov 27, 2017

OK. I think maybe there's a chance someday extensions could have their own activity (adding a new icon in the Activity Bar).

Discussions ongoing: Microsoft/vscode#1833

@eamodio

This comment has been minimized.

Owner

eamodio commented Nov 27, 2017

Yeah, hopefully so -- and when it's available you can be sure I'll add support :)

@jens1o

This comment has been minimized.

jens1o commented Nov 27, 2017

I'd also like to see this happen :)

@tonypee

This comment has been minimized.

tonypee commented Apr 17, 2018

It might also be useful to be able to dock to the bottom panel (not side), as i often find that when i want to browse commits, or file changes, i need to widen the side panel greatly, then to view the diff, the rhs is squished.
I use a veritcal monitor setup which definitely doesnt help this - but just a thought

@eamodio

This comment has been minimized.

Owner

eamodio commented Apr 17, 2018

@tonypee unfortunately GitLens is positioned in the only location allowed by the vscode api currently. When what is allowed changes, I will definitely be open to exploring alternatives.

@ghost

This comment has been minimized.

ghost commented Apr 18, 2018

@tonypee Join the club and watch this related issue on the VSCode repo:
Microsoft/vscode#43645

@ADTC

This comment has been minimized.

ADTC commented May 4, 2018

Reopen! This is now possible, with the latest release. See the related issue linked by ghost above for details. (GitLens could have its own icon in the activity bar. OR it can move to the Source Control view container).

See also, VSCode release notes 1.23.0

@eamodio eamodio self-assigned this May 4, 2018

@eamodio eamodio removed the upstream/vscode label May 4, 2018

@eamodio eamodio reopened this May 4, 2018

@eamodio eamodio added this to the Soon™ milestone May 4, 2018

@eamodio

This comment has been minimized.

Owner

eamodio commented May 4, 2018

@ADTC This is coming in the next release

@ADTC

This comment has been minimized.

ADTC commented May 4, 2018

Will be nice to know how you're choosing to do it. Is it going to be added to Source Control or is it going to be a standalone activity with GitLens icon? Perhaps this could be a user config with Source Control being the default. I think light users wouldn't mind but power users may want to change it to a standalone activity.

Thank you so much for maintaining this!

@eamodio

This comment has been minimized.

Owner

eamodio commented May 4, 2018

My plan is to move GitLens into the SCM activity. I originally thought that I could make it a user choice (SCM vs GitLens' own activity), but currently that really isn't possible with the provided apis/structures.

Hopefully moving to the SCM view is an acceptable compromise.

@eamodio eamodio changed the title from Possible to move GitLens to "Source Control" activity (tab/panel)? to Move GitLens to "Source Control" activity May 4, 2018

@eamodio eamodio closed this May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment