New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better recognition of local GitLab installations #214

Closed
ffes opened this Issue Nov 27, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@ffes

ffes commented Nov 27, 2017

  • GitLens Version: 6.2.0
  • VSCode Version: 1.18.1
  • OS Version: Windows 10

We run a GitLab CE server in our LAN and right now to open the remote I need to add this line to my settings (obviously example.com is replaced with the proper internal name ;-)

"gitlens.remotes": [{ "domain": "gitlab.example.com", "type": "GitLab" }]

But as you can see, the URL contains the part gitlab. It would be great if GitLens would automatically recognize the gitlab part in the URL and open the remote accordingly, so without the need to add the line to the settings.

And yes, when somebody chooses to use git.example.com they still would need to configure that manually.

@eamodio

This comment has been minimized.

Owner

eamodio commented Nov 27, 2017

Let me think about this some more. It feels too fragile to me right now. Another option would be if GitLens detects remotes that aren't currently "built-in" that it could prompt you to setup the remote with GitLens. What do you think about something like that?

@ffes

This comment has been minimized.

ffes commented Nov 27, 2017

That would help indeed, but I still think that when somebody put gitlab in the domain name of a remote it can be safely recognized.

@eamodio eamodio added this to the Backlog milestone Jan 2, 2018

@Yajo

This comment has been minimized.

Yajo commented Sep 21, 2018

Both options seem interesting. It's hard for somebody to have a gitlab.whatever that isn't a gitlab, it seems a sane default.

OTOH, right-click > define remote type would fix all possible corner cases.

@eamodio eamodio modified the milestones: Backlog, Soon™ Sep 30, 2018

@eamodio eamodio self-assigned this Sep 30, 2018

@eamodio eamodio closed this in 5e4b049 Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment