New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"via Terminal" commands need quoting around work directory #310

Closed
SephirXV opened this Issue Mar 12, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@SephirXV

SephirXV commented Mar 12, 2018

  • GitLens Version: 8.1.1
  • VSCode Version: 1.21.0
  • OS Version: Win10 1709

Steps to Reproduce:

  1. Open VSCode in a 'git initialized' directory with a space somewhere in the path
  2. In GITLENS explorer, right click a branch
  3. Select Create Branch (via Terminal) - (all via Terminal commands I've used have same issue)
  4. Enter an arbitray name in the Command Palette
  5. Wait for Terminal to open
  6. Observe 'git -C PATH_WITH_A_SPACE_IN_IT branch ARBITRARY_NAME'

If you hit enter to run the shell command, git gives error about not being able to find dir (listing path earlier up to first space).
What I'm having to do is by hand delete the entire -C PATH portion (already happen to be in right dir), but it seems like quotes around path would be ideal solution.
Perhaps there is a format setting where I can implement this myself?

@eamodio eamodio added the bug label Mar 14, 2018

@eamodio eamodio added this to the Soon™ milestone Mar 14, 2018

@eamodio eamodio self-assigned this Mar 14, 2018

@eamodio eamodio closed this in 7c36083 Mar 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment