New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit messages can causes markdown formatting in hovers #33

Closed
aiiak opened this Issue Feb 27, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@aiiak
Copy link

aiiak commented Feb 27, 2017

When message starts with # symbol, it is displayed as title and looks messy.

img_27022017_094903_0

Do markdown support is really necessary here or just messages is't properly escaped ?
p.s.
If this is a feature, is there some option to disable markdown support in tooltips?

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Feb 27, 2017

@aiiak thanks for the report -- this is a bug. I'm not properly escaping the message.

@eamodio eamodio self-assigned this Feb 27, 2017

@eamodio eamodio added the bug label Feb 27, 2017

@eamodio eamodio closed this in ccd0ad6 Feb 27, 2017

@batisteo

This comment has been minimized.

Copy link

batisteo commented Jun 12, 2017

I think it’s happening again. Could you check if there was a regression?
Using 4.0.1

@eamodio eamodio reopened this Jun 12, 2017

@eamodio eamodio changed the title Commit message styled as title in popup, when message starts with hash symbol Commit messages can causes markdown formatting in hovers Jun 12, 2017

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jun 12, 2017

@batisteo the latest GitLens beta should fix this issue. Please follow these instructions to install a pre-release. Let me know if you experience any issues -- thanks!

@eamodio eamodio closed this in 76961d6 Jun 13, 2017

@jackhorton

This comment has been minimized.

Copy link

jackhorton commented Dec 11, 2018

I believe this is broken again? I am using gitlens 9.0.3 and see the following:

image

@eamodio eamodio reopened this Dec 12, 2018

@eamodio eamodio added this to the Soon™ milestone Dec 12, 2018

@eamodio eamodio closed this in c30725a Dec 12, 2018

@jackhorton

This comment has been minimized.

Copy link

jackhorton commented Dec 12, 2018

thanks for the quick response!

billsedison added a commit to noside911/vscode-gitlens that referenced this issue Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment