New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't stash single files with older versions of Git #381

Closed
tzachshabtay opened this Issue May 24, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@tzachshabtay

tzachshabtay commented May 24, 2018

  • GitLens Version: 8.3.2
  • Git version: 2.7.4
  • VSCode Version: 1.23.1
  • OS Version: Ubuntu 16.04 LTS 64bit

Steps to Reproduce:

  1. Use Git 2.7.4 (which doesn't have "git stash push" but "git stash save"?)
  2. Try to stash files.

Error from the gitlens verbose output channel:

StashSaveCommand Error: Command failed: /usr/bin/git -c core.quotepath=false -c color.ui=false stash push -u -m key -- my_folder/file1.json file2.sh file_3.sh
usage: git stash list [<options>]
   or: git stash show [<stash>]
   or: git stash drop [-q|--quiet] [<stash>]
   or: git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]
   or: git stash branch <branchname> [<stash>]
   or: git stash [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]
		       [-u|--include-untracked] [-a|--all] [<message>]]
   or: git stash clear

This was fixed after I upgraded git to 2.17.0.

So you should either make it compatible with older git versions or give a proper error message "please upgrade to latest git" (or something like that).

@eamodio eamodio self-assigned this May 25, 2018

@eamodio eamodio added the bug label May 25, 2018

@eamodio eamodio added this to the Soon™ milestone May 25, 2018

@eamodio eamodio changed the title from Unable to save stash. See output channel for more details to Can't stash singe files with older versions of Git May 26, 2018

@eamodio eamodio changed the title from Can't stash singe files with older versions of Git to Can't stash single files with older versions of Git May 26, 2018

@eamodio eamodio closed this in 85d9b50 May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment