New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contributing] "pushd: not found" with npm install #392

Closed
cmalard opened this Issue Jun 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@cmalard
Contributor

cmalard commented Jun 4, 2018

  • GitLens Version: 8.3.3
  • VSCode Version: /
  • OS Version: Ubuntu 16.04

Steps to Reproduce:

  1. clone the repo
  2. npm i
> gitlens@8.3.3 postinstall /home/cedric/Projects/vscode-gitlens
> node ./node_modules/vscode/bin/install && pushd "./src/ui" && npm install --no-save && popd

Detected VS Code engine version: ^1.23.0
Found minimal version that qualifies engine range: 1.23.0
Fetching vscode.d.ts from: https://raw.githubusercontent.com/Microsoft/vscode/7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45/src/vs/vscode.d.ts
vscode.d.ts successfully installed!

sh: 1: pushd: not found

Looks like it has something to do with this : https://stackoverflow.com/questions/45630223/how-to-change-shell-of-npm-install
But I don't really see the point of doing this.

Would it be ok to replace pushd / popd by cd / cd - ? It should have the same behavior and increase the compatibility with more systems.

cmalard added a commit to cmalard/vscode-gitlens that referenced this issue Jun 4, 2018

cmalard added a commit to cmalard/vscode-gitlens that referenced this issue Jun 4, 2018

@eamodio eamodio added the bug label Jun 4, 2018

@eamodio eamodio added this to the Soon™ milestone Jun 4, 2018

@eamodio eamodio closed this in 8ceb663 Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment