New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literal $(ellipsis) inserted into commit QuickPick menu entry placeholder text #409

Closed
jarrodldavis opened this Issue Jun 9, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@jarrodldavis

jarrodldavis commented Jun 9, 2018

  • GitLens Version: 8.3.5
  • VSCode Version: Version 1.24.0 (1.24.0)
  • OS Version: macOS High Sierra 10.13.5 (17F77)

Steps to Reproduce:

  1. Open a file that has been committed
  2. Click the Show Commit Details button in the status bar (e.g. "You, 4 years ago")
  3. Observe the placeholder text in the opened QuickPick menu
  4. For some commits, the placeholder text ends with $(ellipsis) rather than

I'm not sure how to specifically reproduce this, as the issue doesn't appear to be consistently caused by commits with long titles (first lines) or with multiple lines.

Here's a demonstration:

http://jmp.sh/dIQA9WL

Here's my GitLens configuration:

  "gitlens.advanced.messages": {
    "suppressResultsExplorerNotice": true,
    "suppressShowKeyBindingsNotice": true,
    "suppressUpdateNotice": true,
    "suppressWelcomeNotice": true
  },
  "gitlens.codeLens.scopes": [
    "document",
    "containers",
    "blocks"
  ],
  "gitlens.defaultGravatarsStyle": "identicon",
  "gitlens.gitExplorer.files.layout": "auto",
  "gitlens.historyExplorer.enabled": true,
  "gitlens.historyExplorer.location": "scm",
  "gitlens.resultsExplorer.location": "scm",
  "gitlens.showWhatsNewAfterUpgrades": false

And here's my current list of installed extensions, as present in ~/.vscode/extensions:

DavidAnson.vscode-markdownlint-0.18.0
EditorConfig.editorconfig-0.12.4
Orta.vscode-jest-2.8.0
PeterJausovec.vscode-docker-0.0.27
WallabyJs.quokka-vscode-1.0.128
austincummings.razor-plus-0.1.4
avli.clojure-0.9.8
dbaeumer.vscode-eslint-1.4.12
eamodio.gitlens-8.3.3
eamodio.gitlens-8.3.5
eg2.tslint-1.0.30
esbenp.prettier-vscode-1.4.0
esbenp.prettier-vscode-1.5.0
felipecaputo.git-project-manager-1.6.1
jinsihou.diff-tool-0.0.1
ms-devlabs.extension-manifest-editor-0.1.5
ms-vscode.csharp-1.15.2
msjsdiag.debugger-for-chrome-4.5.0
msjsdiag.debugger-for-chrome-4.6.0
octref.vetur-0.12.3
octref.vetur-0.12.5
vscodevim.vim-0.12.0
wallabyjs.quokka-vscode-1.0.130

@jarrodldavis jarrodldavis changed the title from Literal $(ellipsis) inserted into commit QuickPick menu to Literal $(ellipsis) inserted into commit QuickPick menu entry placeholder text Jun 9, 2018

@eamodio eamodio self-assigned this Jun 12, 2018

@eamodio eamodio added the bug label Jun 12, 2018

@eamodio eamodio added this to the Soon™ milestone Jun 12, 2018

@eamodio eamodio closed this in 8f30d0b Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment