New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blame heatmap color configurable #419

Closed
AndreasBackx opened this Issue Jun 15, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@AndreasBackx

AndreasBackx commented Jun 15, 2018

The heatmap in the git blame adds a red border for the heatmap which currently is not configurable. It would be nice to add make this configurable.

Related: #360.

@eamodio eamodio self-assigned this Jun 19, 2018

@eamodio eamodio added the feature label Jun 19, 2018

@eamodio eamodio added this to the Soon™ milestone Jun 19, 2018

@eamodio eamodio closed this in 44566b4 Jun 19, 2018

@AndreasBackx

This comment has been minimized.

AndreasBackx commented Jun 19, 2018

Thank you for the quick implementation! I hope to add support for it soon in Rubecula.

@eamodio

This comment has been minimized.

Owner

eamodio commented Jun 19, 2018

No problem. Unfortunately I wasn't able to expose the new colors as theme colors. Because vscode doesn't provide a way to get access to the actual color behind a theme color, which is required for the heatmap

@AndreasBackx

This comment has been minimized.

AndreasBackx commented Jun 20, 2018

Is there an issue of that on the VS Code repo?

@eamodio

This comment has been minimized.

Owner

eamodio commented Jun 20, 2018

@AndreasBackx

This comment has been minimized.

AndreasBackx commented Jun 20, 2018

Awesome, thank you. I'll keep an eye on it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment