Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for commits with an empty query yields to no results anymore #440

Closed
jens1o opened this Issue Jul 6, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@jens1o
Copy link

jens1o commented Jul 6, 2018

  • GitLens Version: 8.4.1
  • VSCode Version:
Version: 1.25.0
Commit: 0f080e5267e829de46638128001aeb7ca2d6d50e
Date: 2018-07-05T13:11:58.697Z
Electron: 1.7.12
Chrome: 58.0.3029.110
Node.js: 7.9.0
V8: 5.8.283.38
Architecture: x64
  • OS Version: Windows 10 Home

Steps to Reproduce:

  1. Execute GitLens: Search Commits
  2. As soon as the search bar appears, hit enter.
  3. Get no results.

Expected behavior:
Get all commits, sorted by last one being first.
Looks like you introduced a breaking change, but I love this feature to get this viewlet. I don't want to use the history bar, because I do not need this feature many times, but when I use it, I'd like it to be like I've been being used to.

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jul 8, 2018

I can't seem to reproduce this behavior (it still shows all commits matching ''). FYI, that output should be the same as GitLens: Show Current Branch History

@jens1o

This comment has been minimized.

Copy link
Author

jens1o commented Jul 8, 2018

Alright.

Trying GitLens: Show Current Branch History I get this message:
image
But I do not get any error in the Developer Tools (the chromium inspector) nor in the Git output. How can I enable more verbose logging?

After following my STR, I see this:
image

As soon as I type something inside, it works perfectly fine:
image

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jul 8, 2018

Is this in a multi-root workspace?

@jens1o

This comment has been minimized.

Copy link
Author

jens1o commented Jul 9, 2018

No, it's not. In this example, I use this repo: https://github.com/WoltLab/WCF

@eamodio eamodio self-assigned this Jul 14, 2018

@eamodio eamodio added this to the Soon™ milestone Jul 14, 2018

@eamodio eamodio closed this in f8e2876 Jul 16, 2018

@jens1o

This comment has been minimized.

Copy link
Author

jens1o commented Jul 16, 2018

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.