Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Control shortcut on macOS (⌃⇧G) shouldn't be overridden #462

Closed
GandalfSaxe opened this Issue Jul 25, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@GandalfSaxe
Copy link

GandalfSaxe commented Jul 25, 2018

Why this?

image

It's evident that GitLens is not using ⌃⇧G for anything, so why make it more cumbersome to go to the Source Control tab by making it ⌃⇧G, G?

Filed as a bug because I can't see any logical explanation for this.

@GandalfSaxe

This comment has been minimized.

Copy link
Author

GandalfSaxe commented Jul 25, 2018

My guess is it's a bad default due to the keymap on windows that does utilize ctrl+shift+G a whole lot:

image

All these commands are instead used on ⌥⌘G on Mac. Therefore the ⌃⇧GG mapping in OP clearly seems like a bug / should be removed :)

@eamodio eamodio self-assigned this Jul 25, 2018

@eamodio eamodio added the type: bug label Jul 25, 2018

@eamodio eamodio added this to the Soon™ milestone Jul 25, 2018

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jul 25, 2018

Thanks for the report -- it is a bad default for the mac, since as you point out GitLens uses ⌥⌘G based chords. Originally it was Ctrl+Alt+G for Windows so it wouldn't conflict with the built-in Ctrl+Shift+G of the SCM view, but Windows treats Ctrl+Alt the same as AltGr (see Microsoft/vscode#41225) any Ctrl+Alt+ shortcut keys must be avoided on Windows. And when I made that change, I didn't change the mac shortcuts but overrode the SCM for all. I will set the mac shortcut back to the default.

@eamodio eamodio changed the title Why is Source Control shortcut (⌃⇧G) overridden? Source Control shortcut on macOS (⌃⇧G) shouldn't be overridden Jul 26, 2018

@eamodio eamodio closed this in 7a34e98 Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.