New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML not escaped in GitLens Explorer sidebar #559

Closed
johnkahn opened this Issue Nov 28, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@johnkahn
Copy link

johnkahn commented Nov 28, 2018

Issue Type: Bug

When a commit message has any html (such as <br />) it won't escape the characters and will instead insert the html into the DOM for vscode. I verified this by looking at the developer tools for vscode.

Steps:

  1. Create a commit with html such as "Commit with <br /> html break"
  2. Open GitLens Explorer in sidebar
  3. Drop down "History" tree to see that the commit only shows "Commit with " (because the rest is on a new line)

Extension version: 8.5.6
VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:06:21.742Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 2, 2
Memory (System) 16.00GB
Process Argv
Screen Reader no
VM 0%
@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Nov 29, 2018

@eamodio eamodio self-assigned this Dec 13, 2018

@eamodio eamodio added this to the Soon™ milestone Dec 13, 2018

@eamodio eamodio closed this Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment