New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open All Changes (with difftool) missing from context menu #569

Closed
kaiseiken opened this Issue Dec 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@kaiseiken
Copy link

kaiseiken commented Dec 4, 2018

"Open All Changes (with difftool)" action previously executed a directory comparison with external difftool (in my case, Meld). Feature was removed/broken following an update to v9.0.1, possibly while fixing bug #503 Open Changes (with difftool), which is similar but executed an individual file comparison for all changes.

  • GitLens Version: 9.0.1
  • VSCode Version: 1.2.9.1
  • OS Version: Ubuntu 18.04.1 LTS / Windows 10 Pro 1703/15063.1446

Steps to Reproduce:

  1. In Source Control:Git panel, right click Changes heading to access context menu.
  2. Observe "Open All Changes (with difftool)" is missing from context menu.
  3. Assign a keybinding to "Open All Changes (with difftool)" command.
  4. Observe that when command is executed via keyboard shortcut, the "Open Changes (with difftool)" action is incorrectly executed instead.

Possible solutions:
Either remove the "Open All Changes (with difftool)" keybinding shortcut from the list (fully deprecating the feature), or add "Open All Changes (with difftool)" action back to context menu and execute a
"directory comparison" with external difftool rather than a file comparison (as previously implemented).

@eamodio eamodio self-assigned this Dec 5, 2018

@eamodio eamodio added the bug label Dec 5, 2018

@eamodio eamodio added this to the Soon™ milestone Dec 5, 2018

@eamodio eamodio closed this in 1fc6ac3 Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment