New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected results when opening diff from file history #584

Closed
turijs opened this Issue Dec 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@turijs
Copy link

turijs commented Dec 9, 2018

  • GitLens Version: 9.0.3
  • VSCode Version: 1.29.1
  • OS Version: Mac OS 10.13.6

When clicking on a commit in the File History pane to open a diff:

Expected:
A diff showing the changes introduced in that commit

Actual:
A diff of the clicked commit with the following commit in the File History (if I'm not mistaken). When history is non-linear, this can cause "extra" changes to show in the diff, which is confusing.

@turijs

This comment has been minimized.

Copy link

turijs commented Dec 9, 2018

I created a minimal repo to demsontrate this as well: https://github.com/turijs/gitlens-issue-584

To reproduce:

  1. Open the above repo in vscode with gitlens
  2. Open the only file in the repo and go to the GitLens File History pane
  3. Click on commit 3, and note that the diff shows changes to "Line 1" and "Line 3", when only "Line 3" was actually changed in that commit.

Is this expected behavior?
Thanks for all the hard work on this extension!

@eamodio eamodio self-assigned this Dec 11, 2018

@eamodio eamodio added the bug label Dec 11, 2018

@eamodio eamodio added this to the Soon™ milestone Dec 11, 2018

@eamodio eamodio closed this in f471073 Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment