New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open file in Remote Doesn't URL encode #607

Closed
ghudik-clgx opened this Issue Jan 4, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@ghudik-clgx
Copy link

ghudik-clgx commented Jan 4, 2019

Open File on Remote Path

https://github.com/org/repo/blob/#162623762-feature/Path/File.cs

Correct URL when file is browsed in Github.com

https://github.com/org/repo/blob/%23162623762-feature/Path/File.cs

As a result Open File in Remote results in 404 in browser in cases where there are special characters in branch name for example.

  • GitLens Version: 9.3.0
  • VSCode Version: 1.30.1
  • OS Version: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Create a Git branch with a special character such as "#"
  2. Push the branch remote
  3. Open file in Remote from Gitlens within VS Code

@eamodio eamodio self-assigned this Jan 4, 2019

@eamodio eamodio added the bug label Jan 4, 2019

@eamodio eamodio added this to the Soon™ milestone Jan 4, 2019

@eamodio eamodio closed this in 7ea3489 Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment