Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version links in CHANGELOG not functional #617

Closed
shadowspawn opened this Issue Jan 9, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@shadowspawn
Copy link
Contributor

commented Jan 9, 2019

The version "reference links" in the headings of the CHANGELOG entries are not functional because the separate URLs are missing. Willing to do a Pull Request if you are interested in adding the reference links to the past releases. (I noticed the issue partly because I had same issue with the Keep a Changelog format myself.)

Example Raw

## [9.4.1] - 2019-01-08

### Fixed

- Reverts #606 as it causes views to lose their expansion state

[9.4.1]: https://github.com/eamodio/vscode-gitlens/compare/v9.4.0...eamodio:v9.4.1

Rendered

9.4.1 - 2019-01-08

Fixed

  • Reverts #606 as it causes views to lose their expansion state

(Thanks for this useful Visual Code extension!)

@eamodio

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2019

@JohnRGee sorry for the delay -- this is a great idea -- thank you. I would definitely welcome a PR 😄

@shadowspawn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

In progress.

@shadowspawn shadowspawn referenced this issue Feb 20, 2019

Merged

Closes #617: Adds version links to CHANGELOG #660

5 of 8 tasks complete
@shadowspawn

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

Submitted Pull Request for consideration.

@shadowspawn shadowspawn closed this Mar 9, 2019

eamodio added a commit that referenced this issue Mar 17, 2019

Closes #617: Adds version links to CHANGELOG
- add version links to show changesets at bottom of document for releases that have both tags
- remove square brackets for versions that are missing tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.