New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch names with only digits always appear first #626

Closed
mlasson opened this Issue Jan 14, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@mlasson
Copy link
Contributor

mlasson commented Jan 14, 2019

Issue Type: Bug

To reproduce, make a branch with a name consisting only of digits (eg. "123") in a repository containing a starred/favorite branch (eg. "master"). Normally, you'll expect to have master appearing first in the list because it is starred but you'll see that the "123" is first:

image

Extension version: 9.4.1
VS Code version: Code - Insiders 1.31.0-insider (e02e44464c02d617b98d0a3265bf5efef7794436, 2018-12-21T06:20:35.852Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.89GB (6.76GB free)
Process Argv
Screen Reader no
VM 0%

@mlasson mlasson referenced this issue Jan 14, 2019

Merged

Avoid using objects to implement Map #627

8 of 8 tasks complete

mlasson added a commit to mlasson/vscode-gitlens that referenced this issue Jan 14, 2019

Fixes eamodio#626 - Avoid using object to implement Map
This commit fixes a bug occurring with branch names which are parsable
integers.

They were always shown first in the list of branches (even if they are
not starred) because the chrome implementation does not respect the
insertion order for keys that happen to be parseable integers.

mlasson added a commit to mlasson/vscode-gitlens that referenced this issue Jan 14, 2019

Fixes eamodio#626 - Avoid using object to implement Map
This commit fixes a bug occurring with branch names which are parsable
integers.

They were always shown first in the list of branches (even if they are
not starred) because the chrome implementation does not respect the
insertion order for keys that happen to be parseable integers.

@mlasson mlasson changed the title Branche names with only digits always appear first Branch names with only digits always appear first Jan 15, 2019

@eamodio eamodio added the type: bug label Jan 23, 2019

@eamodio eamodio added this to the Soon™ milestone Jan 23, 2019

@eamodio eamodio closed this in e1c2c74 Feb 6, 2019

@speed-oss

This comment has been minimized.

Copy link

speed-oss commented Feb 22, 2019

@mlasson if this was helpful to you, consider giving a reward to the issue solver using Speedoss.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment