New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare File with Previous Revision doesn't work if path contains '#' #633

Closed
CCludts opened this Issue Jan 18, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@CCludts
Copy link

CCludts commented Jan 18, 2019

First and foremost, a huge thanks for creating and maintaining gitlens! It is an awesome tool! 馃憤

Steps to Reproduce:

  1. create file in a folder with '#' in the path
  2. commit that file
  3. make change to that file
  4. click 'Open Changes with Previous Revision' in top-right of the screen
    image

Expected: displays diff

Actual: displays nothing, reports error

image

non-verbose logs are empty.

verbose logs:

[2019-01-18 21:39:53:019] [bf] GitService.getBlameForFile completed 鈥 0 ms
[2019-01-18 21:39:53:019] [be] GitService.getBlameForLine completed 鈥 0 ms
[2019-01-18 21:39:56:095] [c0] GitService.getRepoPath
[2019-01-18 21:39:56:095] [c1] GitService.getRepository
[2019-01-18 21:39:56:095] [c2] GitService.isTracked true 鈥 0 ms
[2019-01-18 21:39:56:095] [c1] GitService.getRepository completed 鈥 0 ms
[2019-01-18 21:39:56:095] [c0] GitService.getRepoPath completed 鈥 0 ms
[2019-01-18 21:39:56:095] [c3] GitService.getLogForFile
[2019-01-18 21:39:56:095] [c3] GitService.getLogForFile completed 鈥 0 ms
[2019-01-18 21:39:56:095] [c4] GitService.getStatusForFile
[2019-01-18 21:39:56:142] [e:/coding/_tmp/websocket-sharp] git status --porcelain=v2 -- websocket-sharp/#/hello.cs 鈥 46 ms 
[2019-01-18 21:39:56:142] [c4] GitService.getStatusForFile completed 鈥 46 ms
[2019-01-18 21:39:56:142] [c5] GitService.getRepoPath
[2019-01-18 21:39:56:142] [c6] GitService.getRepository
[2019-01-18 21:39:56:142] [c7] GitService.isTracked true 鈥 0 ms
[2019-01-18 21:39:56:142] [c6] GitService.getRepository completed 鈥 0 ms
[2019-01-18 21:39:56:142] [c5] GitService.getRepoPath completed 鈥 0 ms
[2019-01-18 21:39:56:142] [c8] GitService.findWorkingFileName
[2019-01-18 21:39:56:143] [c8] GitService.findWorkingFileName completed 鈥 0 ms
[2019-01-18 21:39:56:143] [c9] GitService.resolveReference
[2019-01-18 21:39:56:188] [e:/coding/_tmp/websocket-sharp] git cat-file -e 07bb269e55964d7a588b45f7d19ce98847a066c9:./websocket-sharp/#/hello.cs 鈥 44 ms 
[2019-01-18 21:39:56:188] [c9] GitService.resolveReference completed 鈥 45 ms
[2019-01-18 21:39:56:188] [ca] GitService.resolveReference
[2019-01-18 21:39:56:232] [e:/coding/_tmp/websocket-sharp] git cat-file -e :./websocket-sharp/#/hello.cs 鈥 43 ms 
[2019-01-18 21:39:56:232] [ca] GitService.resolveReference completed 鈥 43 ms
[2019-01-18 21:39:56:232] [cb] GitService.getVersionedUri
[2019-01-18 21:39:56:232] [cc] GitService.getVersionedUri
[2019-01-18 21:39:56:232] [cb] GitService.getVersionedUri completed 鈥 0 ms
[2019-01-18 21:39:56:233] [cc] GitService.getVersionedUri completed 鈥 0 ms
[2019-01-18 21:39:56:512] [cd] GitService.getBlameForLine
[2019-01-18 21:39:56:512] [ce] GitService.getBlameForFile
[2019-01-18 21:39:56:512] [ce] GitService.getBlameForFile completed 鈥 0 ms
[2019-01-18 21:39:56:512] [cd] GitService.getBlameForLine completed 鈥 0 ms

GitLens Version: 9.4.1
VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 10.0.17134

@eamodio eamodio self-assigned this Jan 20, 2019

@eamodio eamodio added the type: bug label Jan 20, 2019

@eamodio eamodio added this to the Soon鈩 milestone Jan 20, 2019

eamodio added a commit that referenced this issue Jan 23, 2019

@CCludts

This comment has been minimized.

Copy link
Author

CCludts commented Jan 24, 2019

Thanks for fixing! After manually applied these changes from your commit, everything works properly again.

@CCludts CCludts closed this Jan 24, 2019

@speed-oss

This comment has been minimized.

Copy link

speed-oss commented Feb 22, 2019

@CCludts if this was helpful to you, consider giving a reward to the issue solver using Speedoss.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment