Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure similarity index for diffs #670

Closed
creisle opened this issue Feb 27, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@creisle
Copy link

commented Feb 27, 2019

Is it possible to configure the similarity index when comparing to a branch/tag/etc?

If I were doing this from the command line I would be using the -M/--find-renames flag

For example if I wanted to lower the threshold to 20 (from the default 50)

git diff -M20 <commit>
@eamodio

This comment has been minimized.

Copy link
Owner

commented Mar 8, 2019

Unfortunately there is no way to do that today -- good feature request 😄

x13machine added a commit to x13machine/vscode-gitlens that referenced this issue Apr 12, 2019

@eamodio

This comment has been minimized.

Copy link
Owner

commented Apr 27, 2019

@creisle @x13machine Is a global setting enough for this? Would you likely change this more than once?

In addition to a global default would you like to change the threshold on a per-comparision basis, say via a command or something and you enter a new threshold and it would be applied to that comparison immediately?

@eamodio eamodio added this to the Soonish™ milestone Apr 27, 2019

@creisle

This comment has been minimized.

Copy link
Author

commented Apr 27, 2019

A global setting should be good enough for our use case for now. I imagine once we start using it we could see better if it would be useful to have it per comparison?

Thanks for working on this!

eamodio added a commit to x13machine/vscode-gitlens that referenced this issue Apr 28, 2019

@eamodio eamodio modified the milestones: Soonish™, Soon™ Apr 29, 2019

@eamodio eamodio assigned eamodio and unassigned eamodio Apr 29, 2019

@eamodio eamodio closed this in 2b1777f May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.