Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitService.getBranches very very very long #724

Closed
Tony-Gremillon opened this issue Apr 25, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@Tony-Gremillon
Copy link

commented Apr 25, 2019

  • GitLens Version: 9.6.3
  • VSCode Version: 1.33.1 (user setup)
    Validation : 51b0b28134d51361cf996d2f0a1c698247aeabd8
    Date : 2019-04-11T08:27:14.102Z
    Électron : 3.1.6
    Chrome : 66.0.3359.181
    Node.js : 10.2.0
    V8 : 6.6.346.32
    OS : Windows_NT x64 10.0.16299

Extensions :
project-manager | ale | 10.5.1
cobol | bit | 5.0.4
gitlens | eam | 9.6.3
vscode-language-pack-fr | MS- | 1.33.2
vscode-icons | vsc | 8.6.0

Steps to Reproduce:

  1. Checkout a branch
  2. Deploy "Branches" level and wait very very long time (450893 ms here)

Each time i checkout a branch it take almost the same time

Gitlens log :

[2019-04-25 09:47:45:327] [2c] RepositoriesView.triggerNodeChange — e=RepositoriesNode
[2019-04-25 09:47:45:327] [2c] RepositoriesView.triggerNodeChange completed • 0 ms
[2019-04-25 09:47:45:327] [28] RepositoryNode(0:gitlens:repository(c:/Dev/Git/mdg-source)).refresh completed • 2 ms
[2019-04-25 09:47:45:327] [1b] RepositoriesView.refreshNode completed • 9 ms
[2019-04-25 09:47:45:327] [1a] RepositoriesNode(0).triggerChange completed • 9 ms
[2019-04-25 09:47:45:630] [c:/Dev/Git/mdg-source] git status --porcelain=v2 --branch -u • 571 ms 
[2019-04-25 09:47:45:630] [c:/Dev/Git/mdg-source] git status --porcelain=v2 --branch -u • 308 ms (await) 
[2019-04-25 09:47:45:630] [c:/Dev/Git/mdg-source] git status --porcelain=v2 --branch -u • 305 ms (await) 
[2019-04-25 09:47:45:630] [16] GitService.getStatusForRepo completed • 571 ms
[2019-04-25 09:47:45:630] [25] GitService.getStatusForRepo completed • 309 ms
[2019-04-25 09:47:45:630] [29] GitService.getStatusForRepo completed • 305 ms
[2019-04-25 09:47:45:631] [2d] RepositoryNode(0:gitlens:repository(c:/Dev/Git/mdg-source)).ensureSubscription
[2019-04-25 09:47:45:631] [2d] RepositoryNode(0:gitlens:repository(c:/Dev/Git/mdg-source)).ensureSubscription completed • 0 ms
[2019-04-25 09:47:52:649] [2e] RepositoriesNode(0).onActiveEditorChanged
[2019-04-25 09:47:52:650] [2e] RepositoriesNode(0).onActiveEditorChanged completed • 0 ms
[2019-04-25 09:47:56:765] [2f] GitService.getBranches — e=c:/Dev/Git/mdg-source
[2019-04-25 09:47:56:959] [c:/Dev/Git/mdg-source] git branch -vv --abbrev=40 -a • 193 ms 
[2019-04-25 09:55:27:663] [30] GitService.getRepository — e=c:/Dev/Git/mdg-source
[2019-04-25 09:55:27:663] [30] GitService.getRepository returned c:/Dev/Git/mdg-source • 0 ms
[2019-04-25 09:55:27:663] [2f] GitService.getBranches completed • **450893** ms
[2019-04-25 09:55:28:343] [31] RepositoriesNode(0).onActiveEditorChanged
[2019-04-25 09:55:28:343] [31] RepositoriesNode(0).onActiveEditorChanged completed • 0 ms

Gitlens (Git) log :

[2019-04-25 09:47:38:287] [c:\Dev\Git\mdg-source] git rev-parse --show-toplevel • 658 ms 
[2019-04-25 09:47:39:593] [c:/Dev/Git/mdg-source] git remote -v • 408 ms 
[2019-04-25 09:47:39:865] [c:/Dev/Git/mdg-source] git ls-files -- srvcbl/src/main/cbl/lib/CC0146M.cbl • 196 ms 
[2019-04-25 09:47:39:875] [c:\Users\re46rh\AppData\Roaming\Code\User] git rev-parse --show-toplevel • 195 ms 
[2019-04-25 09:47:40:027] [c:/Dev/Git/mdg-source] git ls-files -- c:\Dev\Git\mdg-source\srvcbl\src\main\cbl\lib\CC0146M.cbl • 160 ms 
[2019-04-25 09:47:40:044] [] git ls-files -- c:\Users\re46rh\AppData\Roaming\Code\User\settings.json • 167 ms 
[2019-04-25 09:47:40:528] [c:/Dev/Git/mdg-source] git blame --root --incremental -- srvcbl/src/main/cbl/lib/CC0146M.cbl • 498 ms 
[2019-04-25 09:47:40:662] [c:/Dev/Git/mdg-source] git config --get-regex user.(name|email) • 133 ms 
[2019-04-25 09:47:40:778] [c:/Dev/Git/mdg-source] git check-mailmap Tony Gremillon <tony.gremillon@cegedim-activ.com> • 116 ms 
[2019-04-25 09:47:45:630] [c:/Dev/Git/mdg-source] git status --porcelain=v2 --branch -u • 571 ms 
[2019-04-25 09:47:45:630] [c:/Dev/Git/mdg-source] git status --porcelain=v2 --branch -u • 308 ms (await) 
[2019-04-25 09:47:45:630] [c:/Dev/Git/mdg-source] git status --porcelain=v2 --branch -u • 305 ms (await) 
[2019-04-25 09:47:56:959] [c:/Dev/Git/mdg-source] git branch -vv --abbrev=40 -a • 193 ms 

This repo is the biggest that we have but last week i didn't have the problem
On other repo i don't have this problem

Thx
Tony

@eamodio

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

@Tony-Gremillon is this a repo that I can have access to? Or if not, can you send me the output of git branch -vv --abbrev=40 -a so that I can debug the parsing?

@Tony-Gremillon

This comment has been minimized.

Copy link
Author

commented Apr 26, 2019

Hello,
no you can't have access, here is the result of the command :
git branch -vv --abbrev=40 -a.txt

Thanks

@eamodio eamodio self-assigned this Apr 27, 2019

@eamodio eamodio added this to the Soon™ milestone Apr 27, 2019

eamodio added a commit that referenced this issue Apr 27, 2019

Fixes #724 - catastrophic backtracking regex
Reworks branch parsing to use for-each-ref

@eamodio eamodio closed this in d9e3342 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.