Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show more results"in search commit show less results #729

Closed
janosimas opened this issue Apr 30, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@janosimas
Copy link

commented Apr 30, 2019

  • GitLens Version: 9.6.3
  • VSCode Version: 1.33.1
  • OS Version: Windows 10.0.17134

Steps to Reproduce:

  1. When searching for commits of an author, for example
    the maximum number of results is 200
    GitService.getLogForSearch — e=d:/some/path, t=somename, i=author, o={}

  2. Clicking in "show more results" show only 40 results
    GitService.getLogForSearch — e=d:/some/path, t=somename, i=author, o={"maxCount":40}

  3. Clicking in "show more results" increase the number of results by 20
    GitService.getLogForSearch — e=d:/some/path, t=somename, i=author, o={"maxCount":60}

Sugestion:
Aside from fixing showing less instead of showing more, maybe it would be better to show twice the number of commits when showing more instead of increasing by 20.

@eamodio eamodio added the type: bug label Apr 30, 2019

@eamodio eamodio added this to the Soon™ milestone Apr 30, 2019

@eamodio eamodio self-assigned this Apr 30, 2019

@eamodio eamodio closed this in 6659853 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.