Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activity bar icon size #743

Closed
misolori opened this issue May 8, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@misolori
Copy link
Contributor

commented May 8, 2019

I realized that the VS Code icon specs for extension viewlets was worded wrong (my mistake). The activity bar icons should only be 28x28.

I'm currently working through the iconography re-design issue, and also exploring alternate ways to size the activity bar icons via mask sizes. Because the Gitlens svg is 50x40 (because that's what the docs said 😛) the entire icon gets resized improperly.

image

The correct fix would be to update the svg to be 28x28. I can create a PR for this.

@misolori misolori referenced this issue May 8, 2019

Merged

Update activity bar icon size #744

8 of 8 tasks complete

@eamodio eamodio added this to the Soon™ milestone May 10, 2019

@eamodio eamodio closed this May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.