Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated directory names in commit preview #769

Closed
nbozhinov opened this issue Jun 21, 2019 · 6 comments

Comments

@nbozhinov
Copy link

commented Jun 21, 2019

Previewing a commit in the "repositories view" sometimes duplicates the names of some directories when showing the changed files so instead of "repo/dir1/dir2/dir3" I see "repo/dir1/dir2/dir2/dir3" which is a nonexistent path.

GitLens version: 9.8.2
VS Code version: 1.34.0
OS: Ubuntu 16.04 LTS

@eamodio

This comment has been minimized.

Copy link
Owner

commented Jul 9, 2019

@nbozhinov are there symlinks at play here?
Can you please enable output channel logging by setting "gitlens.outputLevel": "debug" in your settings.json. This will enable logging to the GitLens channel in the Output pane. Once enabled, please reproduce the issue (if possible) and attach the log lines from the GitLens channel.

@nbozhinov

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

@eamodio no there are no symlinks in the paths that show this problem.
I've enabled the debug logging an am attaching the output from when the problem appeared. I've renamed my user and the project name due to company policy, but structure of the paths is preserved.
gitlens_debug_output.txt
Unfortunately I cannot see a sign of the duplication in the log - neither the attached one, nor in the output from my current vscode session. However the commits and paths that get this duplication seem to be consistent within one vscode session.

@eamodio

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2019

@nbozhinov First is this still happening with v9.9.1? If so, in that log what paths would get duplicated? You mentioned that it "sometimes" happens -- it is at least consistent with the same files? Or any other details that you can tell me to help see it?

@nbozhinov

This comment has been minimized.

Copy link
Author

commented Jul 23, 2019

@eamodio yes it still happens with v9.9.1. It appears to be consistent with the same directory, but happens only on some commits, on others with the same files edited it appear normally. Also the problematic commit appears properly when viewed in GitLab.
The broken file path looks like this:
Screenshot from 2019-07-23 18-21-07
The directory "arch" should appear only once. This is in the "repositories" panel when previewing the current branch. This commit has been amended if this is of any relevance.
I am attaching the log from when the screenshot was taken, but it still doesn't mention this directory at all.
gitlens_debug.txt

@eamodio

This comment has been minimized.

Copy link
Owner

commented Jul 25, 2019

Can you provide the output of the following git command, replacing <your-commit-id-here> with the sha of a commit that shows this file issue?

git log --name-status --format="%x3c%x2ff%x3e%n%x3cr%x3e%x20%H%n%x3ca%x3e%x20%aN%n%x3ce%x3e%x20%aE%n%x3cd%x3e%x20%at%n%x3cc%x3e%x20%ct%n%x3cp%x3e%x20%P%n%x3cs%x3e%n%B%n%x3c%x2fs%x3e%n%x3cf%x3e" -n1 -m -M <your-commit-id-here>
@eamodio

This comment has been minimized.

Copy link
Owner

commented Sep 24, 2019

I am closing this issue because it needs more information and has not had recent activity. Please re-open this issue when more details can be provided.

Thanks!

@eamodio eamodio closed this Sep 24, 2019
@eamodio eamodio reopened this Oct 2, 2019
@eamodio eamodio self-assigned this Oct 2, 2019
@eamodio eamodio added this to the Soon™ milestone Oct 2, 2019
@eamodio eamodio closed this in f66c81c Oct 6, 2019
@eamodio eamodio removed this from the Soon™ milestone Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.