Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Branch diff against master shows incorrect files in two-dot mode #797
@borekb That behavior, while a bit confusing, is working correctly. Basically the issue is that when using the 2-dot (range) syntax the order of the compare matters, i.e.
So in the repository compare, I am always showing
While the 2nd compare (in the compare view), the order is determined by how you select what to compare (which you can easily swap). In your case that is:
If you swap the compare, so it says Comparing master to 211-component-for-complex-l18n the 2 comparisons will match.
Given that, you can certainly argue that what I display in the repo compare is somewhat misleading, but to me it felt odd/wrong to switch the display order (e.g. to say
Oh I see, it's indeed quite a UX challenge then. How about unifying the two this way:
It doesn't look that good without colors but if the current branch stood out, maybe this could work? I'm generally happy when it's clear from the UI what I'm looking at.
One problem with the above is what to do when