Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong commit diff in file history #809

Closed
dvdveer opened this issue Jul 31, 2019 · 0 comments

Comments

@dvdveer
Copy link

commented Jul 31, 2019

When you view the commit changes of a file in e.g. file history or repository history, sometimes the diff is wrong. I noticed this problem in particular when a file was changed in multiple branches. In that case the shown diff is not from the individual commit, but somehow shows changes from other commits as well.

This appears to be the same issue as #584 (which was fixed some time ago), you can even use the repository that was created for the isssue to reproduce it: https://github.com/turijs/gitlens-issue-584

I can reproduce this issue in the current Gitlens version (9.9.1) going back to 9.7.0. In gitlens version 9.6.3 it works normally however.

  • GitLens Version: 9.9.1
  • VSCode Version: 1.36.1
  • OS Version: macOS Mojave (also seen on Windows 10)

Steps to Reproduce:

  1. Clone repository https://github.com/turijs/gitlens-issue-584 and open in vscode with gitlens
  2. Open the only file in the repo and go to the GitLens File History pane
  3. Click on commit 3, and note that the diff shows changes to "Line 1" and "Line 3", when only "Line 3" was actually changed in that commit.

Gitlens 9.9.1 (wrong):
Screenshot 2019-07-31 at 10 51 58

Gitlens 9.6.3 (OK):
Gitlens 9.6.3

@eamodio eamodio added the type: bug label Jul 31, 2019

@eamodio eamodio added this to the Soon™ milestone Jul 31, 2019

@eamodio eamodio self-assigned this Jul 31, 2019

@eamodio eamodio closed this Aug 1, 2019

@eamodio eamodio removed this from the Soon™ milestone Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.