Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting stash doesn't remove the stash from the list - have to refresh #826

Closed
admehta01 opened this issue Aug 21, 2019 · 13 comments

Comments

@admehta01
Copy link

commented Aug 21, 2019

  • GitLens Version: 9.9.3
  • VSCode Version: 1.37.1
  • OS: Windows 10

Steps to Reproduce:

  1. Stash something
  2. In GitLens right click -> Delete Stashed Changes
    The list doesn't update. If you try to delete again, it deletes another stash. Potentially disastrous bug.

If you refresh the whole view, then it correctly disappears from the view.

@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 25, 2019

@admehta01 I can't reproduce this behavior. Do you have automatic refresh of the Repositories view turned off?

@admehta01

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

Here are my settings:

image

@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 26, 2019

@admehta01 Hrm, can you please enable output channel logging by setting "gitlens.outputLevel": "debug" in your settings.json. This will enable logging to the GitLens channel in the Output pane. Once enabled, please reproduce the issue and attach the log lines from the GitLens channel. Thanks!

@admehta01

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

[2019-08-26 03:41:21:751] [1a4c] GitService.stashDelete — e=c:/Github/app, t=stash@{0}
[2019-08-26 03:41:24:292] [c:/Github/app] git stash drop stash@{0} • 2541 ms 
[2019-08-26 03:41:24:293] [1a4c] GitService.stashDelete completed • 2541 ms
@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 26, 2019

@admehta01 I need the logs that happen after the stashDelete call too -- I want to look at how the view responds (or doesn't) to the repository change

@admehta01

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 26, 2019

If you click on the ... menu of the Repositories view do you see this:
image

Does it say enable or disable?

@admehta01

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

It says "Disable Automatic Refresh":

image

@ShinaZin

This comment has been minimized.

Copy link

commented Sep 23, 2019

Because of this error, deleting changes from the Stashes list can be very dangerous. May result in erroneous deletion of changes. 😞

@eamodio

This comment has been minimized.

Copy link
Owner

commented Sep 24, 2019

@admehta01 @ShinaZin I can't seem to reproduce this for the life of me. Is there any other specific details that you can provide? OS, using VS Code remote? Remote file system? File share? etc?

@ShinaZin

This comment has been minimized.

Copy link

commented Sep 24, 2019

VS Code
Version: 1.38.1 (user setup)
Commit: b37e54c98e1a74ba89e03073e5a3761284e3ffb0
Date: 2019-09-11T13:35:15.005Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 6.1.7601
GitLense v10.0.1

Using filesystem: NTFS
Repo .git/config file:

[core]
	repositoryformatversion = 0
	filemode = false
	bare = false
	logallrefupdates = true
	symlinks = false
	ignorecase = true
	autocrlf = false
[remote "origin"]
	url = deleted
	fetch = deleted
[branch "master"]
	remote = origin
	merge = refs/heads/master
[gui]
	wmstate = normal
	geometry = 1005x515+358+184 175 196

StashError

@eamodio

This comment has been minimized.

Copy link
Owner

commented Sep 25, 2019

Ah! Now I see. Thank you @ShinaZin for the full screenshot! So the basic issue is that the repository it outside of the opened workspace -- so vscode (and in turn) GitLens is unable to get file system change events for it. So I will need to manually cause a refresh when actions are taken.

While its subtle, you can see in the Repositories view there is a <!> next to the repository name -- which is the indicator of this (and it mentions it in the tooltip for the repo as well).

@admehta01 is this the same for you? Do you see a <!> indicator next to the repositories that you are experiencing this issue with?

@eamodio eamodio self-assigned this Sep 25, 2019
@eamodio eamodio added this to the Soon™ milestone Sep 25, 2019
@admehta01

This comment has been minimized.

Copy link
Author

commented Sep 27, 2019

Yes, that's in my screenshot as well. What do you mean by "repository it outside of the opened workspace"?

@eamodio eamodio closed this in 101f265 Oct 6, 2019
@eamodio eamodio removed this from the Soon™ milestone Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.