Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version comparison to show welcome message is not future proof #828

Closed
arajkumar opened this issue Aug 26, 2019 · 0 comments
Assignees
Labels

Comments

@arajkumar
Copy link
Contributor

@arajkumar arajkumar commented Aug 26, 2019

(major < prevMajor || (major === prevMajor && minor < prevMinor))

The above snippet uses < operators on string values. It works now , it will fail when the version is bumped to 9.10.x or 10.x.x.

arajkumar added a commit to arajkumar/vscode-gitlens that referenced this issue Aug 26, 2019
@eamodio eamodio added this to the Soon™ milestone Sep 3, 2019
@eamodio eamodio added the type: bug label Sep 3, 2019
@eamodio eamodio closed this in 53e9cd1 Sep 20, 2019
@eamodio eamodio removed this from the Soon™ milestone Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.