Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refresh button on Compare With Branch view is not working #847
Issue Type: Bug
Clicking on the Refresh buttons (both at the level of the individual comparison, and at the level of the entire Compare pane) does nothing.
Extension version: 9.9.3
It could have worked differently before, I did a bunch of work to avoid re-query unless it was an explicit action. There we many cases before were queries could happen multiple times and depending on the query/compare it could be very expensive.
What is the use-case for needing to requery a set of compares?
I sometimes keep two or more comparisons open. For example, one against master, one against a target branch that I'm cleaning up. That global Refresh button allowed me to refresh all the comparisons in one click. Clicking on each individual Refresh button now requires multiple clicks, plus scrolling when comparisons show a lot of files.
On top of that (and even more importantly IMO), since it used to work before, there's the habit of just clicking on that global Refresh button, and relying on it. Now that that Refresh button doesn't refresh the comparisons anymore, I could come to the wrong conclusion about the current content of a branch, which could have a disastrous impact.
I don't think a global Refresh button that just repaints is useful. I'd rather not having it at all, than clicking on it and thinking that it's actually refreshing.
I think it used to work perfectly before. If performance is a concern, the user always has the choice of how many comparisons to keep around, so I don't see a problem there.