Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra backslash in the hovers blame detail's link #849

Closed
bryceyang opened this issue Sep 10, 2019 · 2 comments

Comments

@bryceyang
Copy link

commented Sep 10, 2019

  • GitLens Version: v9.9.3
  • VSCode Version: Version: 1.39.0-insider, latest stable version also has the problem.
  • OS Version: macOS Mojave 10.14.6

Steps to Reproduce:

  1. move cursor to the git line blame, then the blame details contain some related issue links pop up;
  2. check the end of the links

further desc:
The correct link in blame detail should be: https://somedomain.com/repo/merge_request_id,
but actually, it is: https://somedomain.com/repo/merge_request_id\.
The link with an extra backslash can't be accessed by chrome except I remove the \ manually.
Check the pic below:

Screen Shot 2019-09-10 at 9 18 41 PM

.
@eamodio

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

@bryceyang those links are included in the commit message itself correct?

@bryceyang

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

@bryceyang those links are included in the commit message itself correct?

Hi, I checked the commit message.
The links in the origin commit message are surrounded by a pair or angle brackets.
Like: Tested-by: <https://somedomain.com/repo/merge_requests/id>

So the brackets could be the reason cause the extra backslash?

@eamodio eamodio added this to the Soon™ milestone Sep 11, 2019
@eamodio eamodio changed the title extra backslash in the pop-up blame detail's link. Extra backslash in the hovers blame detail's link Sep 11, 2019
@eamodio eamodio closed this in 6f13cec Sep 20, 2019
@eamodio eamodio removed this from the Soon™ milestone Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.