Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autolink support (custom link detection in commit messages) #897

Closed
jonfen opened this issue Nov 5, 2019 · 4 comments
Closed

Add autolink support (custom link detection in commit messages) #897

jonfen opened this issue Nov 5, 2019 · 4 comments
Labels
Milestone

Comments

@jonfen
Copy link

@jonfen jonfen commented Nov 5, 2019

The default points to the git repo on gitlab, but we use a separate redmine server to handle issues.

@eamodio

This comment has been minimized.

Copy link
Owner

@eamodio eamodio commented Nov 6, 2019

Currently there really isn't a way to support this -- but I am planning on a more flexible version of the link detection feature that should allow this.

@eamodio eamodio added type: feature and removed type: question labels Nov 6, 2019
@eamodio eamodio added this to the Soonish™ milestone Nov 6, 2019
@eamodio eamodio changed the title How do we redirect the hovers blame detail's link to a separate server? Add support for custom link detection in commit messages (e.g. hovers) Nov 6, 2019
@eamodio eamodio changed the title Add support for custom link detection in commit messages (e.g. hovers) Add autolink support (custom link detection in commit messages) Nov 11, 2019
@eamodio

This comment has been minimized.

Copy link
Owner

@eamodio eamodio commented Nov 11, 2019

Add the ability to create "autolinks" which will match patterns in commit messages and linkify them. For example, if a commit message contains JIRA-123 then turn it into a link like https://jira.github.com/issue?query=123.

Ref: #346

@eamodio eamodio modified the milestones: Soonish™, Soon™ Nov 18, 2019
@eamodio eamodio closed this in 59e7685 Nov 18, 2019
@jonfen

This comment has been minimized.

Copy link
Author

@jonfen jonfen commented Dec 3, 2019

@Sigura

This comment has been minimized.

Copy link

@Sigura Sigura commented Dec 6, 2019

@jonfen I know it closed. But let me please describe one of use case because I'm sure - I'm not alone with this pain.

First thank you for your amazing work!

Precondition: we have a rule - add issue # to commit description (after subject\n\n).
Desired behavior: issue # at current line with link to our tracker

Partially it solved with autolink (thanks again!)

My suggestions:

  • add {issue} template to gitlens.currentLine.format for first found link. It will looks like: ${author} • ${issue} ${message}
  • show commit description in current line too after few seconds below it (without popup) and gitlens.currentLine.inlineDetails for those things

I know it not a main use case and I think it's bunch of work. That is why this message added to closed task. If you have not time or environment for this feature request, just skip it. If any idea or part of it close to you, that is nice for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.