New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add another unknownRevision error to detect #390

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@ryenus
Contributor

ryenus commented Jun 1, 2018

The following error also caused blame not working:

git rev-parse --symbolic-full-name my_branch@{u}
fatal: upstream branch 'refs/heads/my_branch' not stored as a remote-tracking branch

Git version: 2.17.1

add another unknownRevision error
The following error also caused blame not working:

> git rev-parse --symbolic-full-name my_branch@{u}
fatal: upstream branch 'refs/heads/my_branch' not stored as a remote-tracking branch
@ryenus

This comment has been minimized.

Contributor

ryenus commented Jun 1, 2018

Tested locally and it works, with this change the inline blame and comparing with previous revision works as expected.

But I wonder if it's possible to skip resolving the remote tracking branch? Is it possible to add an option to disable this behavior?

@ryenus ryenus changed the title from add another unknownRevision error to add another unknownRevision error to detect Jun 3, 2018

@eamodio eamodio changed the base branch from master to develop Jun 4, 2018

@eamodio eamodio merged commit 4fef40a into eamodio:develop Jun 4, 2018

@eamodio

This comment has been minimized.

Owner

eamodio commented Jun 4, 2018

Thank you for your contribution! 👍

As for skipping, I use the information about the remote branch to enable/disable other GitLens features (and it is only done once), so I don't see a compelling reason to have an option to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment