New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #392 - unable to contribute if default script shell is sh #393

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@cmalard
Contributor

cmalard commented Jun 4, 2018

No description provided.

@eamodio

This comment has been minimized.

Owner

eamodio commented Jun 4, 2018

Thank you for the contribution, but unfortunately I can't accept this as this doesn't work on Windows (my primary dev environment).

@cmalard

This comment has been minimized.

Contributor

cmalard commented Jun 4, 2018

I replaced cd - by cd ../.. (with all those stuff that should make it compatible with Windows (cd \"../..\"), could you give it a try ? 🤔

@cmalard cmalard changed the base branch from master to develop Jun 4, 2018

@eamodio

This comment has been minimized.

Owner

eamodio commented Jun 4, 2018

Yup that works fine, sucks that pushd/popd isn't supported everywhere

@eamodio eamodio merged commit 8ceb663 into eamodio:develop Jun 4, 2018

@cmalard cmalard deleted the cmalard:pushd-cd branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment