New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravartars not showing if email contained upper case characters #579

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@sgtwilko
Copy link

sgtwilko commented Dec 6, 2018

The email address was being correctly manipulated for the lookup of the Gravatar from local cache, but when the call to Gravatar was made for one that wasn't in the local cache the email was not being run via trim() and toLowerCase().

This has been causing the avatars to fail to show for valid accounts.

@eamodio eamodio changed the base branch from master to develop Dec 6, 2018

@eamodio eamodio merged commit 4e801bc into eamodio:develop Dec 6, 2018

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Dec 6, 2018

Thank you!

@sgtwilko sgtwilko deleted the sgtwilko:FixGravatarWrongURLs branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment