New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #608] Adds the option to change the length of the abbreviated commit SHA #611

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@Luxray5474
Copy link
Contributor

Luxray5474 commented Jan 6, 2019

Description

I am working on a documentation project that I have made a spreadsheet planner for, and entering the ID of the latest commit touching a given feature is required. Since the project is on GitLab, and said Git host has 8-character-long commit abbreviations, I have gotten used to the 8-character length. However, while pasting the commit ID from GitLens, I was surprised to find that it was only 7, which also frustrated me. This PR aims to allow the user to change the length of the abbreviated commit SHA, and relieve the frustration caused by inconsistencies in abbreviated commit ID length across multiple Git clients/hosts/software.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes are based off of the develop branch
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings (are linebreak and no-floating-promises warnings considered as such?)
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio merged commit 6a5e001 into eamodio:develop Jan 8, 2019

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jan 8, 2019

@Luxray5474 Excellent work! Thanks for the contribution! This will be part of GitLens 9.4 🎉

@eamodio eamodio self-requested a review Jan 8, 2019

@eamodio eamodio added this to the Soon™ milestone Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment