New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #620: Add missing _git in Azure DevOps URLs. #621

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@Eskibear
Copy link
Contributor

Eskibear commented Jan 10, 2019

Description

This PR fixes the missing _git issue mentioned in #620

But it doesn't fix the issue cause by the following cloning URL which requires reformatting the domain.
<org>@vs-ssh.visualstudio.com:v3/<org>/<project>/<repo>

About the linting, there's a warning but it's not introduced by this PR.

WARNING: vscode-gitlens/src/vsls/host.ts:78:9 - Promises must be handled appropriately

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes are based off of the develop branch
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Eskibear and others added some commits Jan 10, 2019

Reworks Azure DevOps remote parsing
Fixes vs-ssh domain issue
Adds better display path for ADO remotes
Adds full urls to remote tooltips

@eamodio eamodio merged commit c4a83e7 into eamodio:develop Jan 23, 2019

@eamodio

This comment has been minimized.

Copy link
Owner

eamodio commented Jan 23, 2019

@Eskibear Thank you so much for you contribution!

@eamodio eamodio self-assigned this Jan 23, 2019

@Eskibear Eskibear deleted the Eskibear:dev-ops branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment