Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #828 - Convert version fields to int before comparing it #829

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@arajkumar
Copy link
Contributor

commented Aug 26, 2019

Description

Convert string filed into integer before comparing it.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes are based off of the develop branch
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses
@arajkumar arajkumar force-pushed the arajkumar:fix-version-comparison branch from 44814f8 to a2e8fda Aug 26, 2019
@arajkumar arajkumar changed the base branch from master to develop Aug 26, 2019
@arajkumar arajkumar force-pushed the arajkumar:fix-version-comparison branch from a2e8fda to 5d388b9 Aug 26, 2019
src/extension.ts Outdated Show resolved Hide resolved
@eamodio eamodio merged commit 0e64256 into eamodio:develop Aug 27, 2019
@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 27, 2019

Thank you for your contribution!

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.