From d46c654b5002e5ce2afc91bc5127f239b7a0a898 Mon Sep 17 00:00:00 2001
From: Haytham AbuelFutuh <habuelfutuh@lyft.com>
Date: Tue, 5 May 2020 13:32:00 -0700
Subject: [PATCH] Populate ExecutionError Kind from Container Errors (#83)

---
 .../pluginmachinery/ioutils/remote_file_output_reader.go     | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go b/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go
index 52c3a100b1..f6da3957d9 100644
--- a/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go
+++ b/go/tasks/pluginmachinery/ioutils/remote_file_output_reader.go
@@ -42,6 +42,7 @@ func (r RemoteFileOutputReader) ReadError(ctx context.Context) (io.ExecutionErro
 				ExecutionError: &core.ExecutionError{
 					Code:    "ErrorFileNotFound",
 					Message: err.Error(),
+					Kind:    core.ExecutionError_SYSTEM,
 				},
 			}, nil
 		}
@@ -54,6 +55,7 @@ func (r RemoteFileOutputReader) ReadError(ctx context.Context) (io.ExecutionErro
 			ExecutionError: &core.ExecutionError{
 				Code:    "ErrorFileBadFormat",
 				Message: fmt.Sprintf("error not formatted correctly, nil error @path [%s]", r.outPath.GetErrorPath()),
+				Kind:    core.ExecutionError_SYSTEM,
 			},
 		}, nil
 	}
@@ -62,11 +64,14 @@ func (r RemoteFileOutputReader) ReadError(ctx context.Context) (io.ExecutionErro
 		ExecutionError: &core.ExecutionError{
 			Code:    errorDoc.Error.Code,
 			Message: errorDoc.Error.Message,
+			Kind:    core.ExecutionError_USER, // TODO: read it from container error once populated by SDK
 		},
 	}
+
 	if errorDoc.Error.Kind == core.ContainerError_RECOVERABLE {
 		ee.IsRecoverable = true
 	}
+
 	return ee, nil
 }