SF_printable_fix #130
Merged
SF_printable_fix #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Printable.h in dir where it can be found
Still need a unique -D... in the compile cmd so can know to add
namespace arduino {
to SafeString.h
|
I've submitted the -D additions with |
earlephilhower
added a commit
that referenced
this pull request
May 13, 2021
Per #130 request, the dtostrf() definition and others were not visible.
earlephilhower
added a commit
that referenced
this pull request
May 13, 2021
Per #130 request, the dtostrf() definition and others were not visible.
|
#131 adds the non ISO stuff to standard Arduino includes, so covers dtostrf, even though I don't see it used... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User requested SafeString library support be added for this project.
https://forum.arduino.cc/t/libraries-updated-to-support-new-rp2040-based-boards-raspberry-pi-pico-etc/860353/3
Current SafeString library works for Arduino Mbed OS RP2040 V2.0.0 board install
This pull request fixes missing Printable.h file
But in order to complete adding the support need a unique define (-D... = .. ) that can be detected by SafeString.h so that the
necessary
namespace arduino {
can be set
Arduino Mbed OS RP2040 V2.0.0 has a -DARDUINO_ARCH_MBED_RP2040 define
Can you add a -D to your compile line (and when Arduino detects libraries)
Also dtostrf( ) declaration not found by SafeString library (works with Arduino pico, fixed by an extern ... in SafeString.h )