Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested updates to README #456

Merged
merged 1 commit into from Nov 13, 2019
Merged

Suggested updates to README #456

merged 1 commit into from Nov 13, 2019

Conversation

arfon
Copy link
Contributor

@arfon arfon commented Nov 13, 2019

馃憢 @lwasser - this PR does two things:

  1. Updates the preferred citation for the package to link to the JOSS paper.
  2. Removes the Zenodo DOI badge - rationale that this is likely to cause confusion to users, especially if you want to encourage citation of the paper rather than a Zenodo DOI?

@lwasser
Copy link

lwasser commented Nov 13, 2019

馃憢 @arfon awesome - thank you for this. i'll merge once CI is happy. Much appreciated. i was actually just going to ping you on the two sets of DOI's. Orcid already has registered the JOSS citation so that is preferred on my end!! many thanks for walking me through this process.

Also Whedon is absolutely awesome. what a friendly bot that walked me through the review process. i'd love to touch base with you at some point on using whedon again for pyopensci. just to revisit that idea! whedon should get funding to support open source review processes in general as you had alluded to!!

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #456   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files          25     25           
  Lines        1660   1660           
=====================================
  Hits         1577   1577           
  Misses         83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cbf12d3...1805290. Read the comment docs.

@arfon
Copy link
Contributor Author

arfon commented Nov 13, 2019

Also Whedon is absolutely awesome. what a friendly bot that walked me through the review process. i'd love to touch base with you at some point on using whedon again for pyopensci. just to revisit that idea! whedon should get funding to support open source review processes in general as you had alluded to!!

Definitely, would love to!

@lwasser lwasser self-requested a review November 13, 2019 23:20
@lwasser
Copy link

lwasser commented Nov 13, 2019

thank you @arfon merging now!!

@lwasser lwasser merged commit 21c0c35 into earthlab:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants