SCALAR: Improve handling skipping of empty data #889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we work with empty data on
skip_empty=True
.When using
filter_by_rank
now empty stations are skipped based on actual percentage of values which is calculated for all requested parameters per station.Thresholds for it can be defined with
skip_criteria
which is one of "min", "mean", "max", whereBecause we don't know from the start which station has enough values, after collecting all data there is a property on the values class named
df_stations
that holds all stations that were finally collected, so that you can get a sense for the data.