Permalink
Browse files

TODO comments removed, amended

  • Loading branch information...
Balazs Bucsay
Balazs Bucsay committed Jun 3, 2018
1 parent 540dc9f commit 80c3d0379f213738ae1f8fb90ac418cec393b2ac
Showing with 3 additions and 10 deletions.
  1. +1 −5 modules/ICMP.py
  2. +1 −2 modules/Stateful_module.py
  3. +0 −2 modules/TCP_generic.py
  4. +1 −1 modules/UDP_generic.py
@@ -43,10 +43,6 @@
from support.icmp_proto import ICMP_Proto
from support.icmp_proto import ICMP_Client
#TODO: reverse check from the server
# if the client does not answer, the packets does not go thru
# seq must be modified.
class ICMP(Stateless_module.Stateless_module):
module_name = "ICMP"
@@ -228,7 +224,7 @@ def do_check(self):
# start talking to the server
# do authentication or encryption first
def do_hello(self):
# TODO: maybe change this later to push some more info, not only the
# TODO: maybe change this later to push some more info, not just the
# private IP
message = socket.inet_aton(self.config.get("Global", "clientip"))
self.send(common.CONTROL_CHANNEL_BYTE, common.CONTROL_INIT+message,
@@ -143,7 +143,6 @@ def packet_reader_default(self, tunnel, first_read, serverorclient):
packet = os.read(tunnel, 4096)
return packet
# TODO: placeholder function to transform packets back and forth.
# encryption, encodings anything that should be done on the packet and
# should be easily variable based on the config
def transform(self, details, packet, encrypt):
@@ -338,7 +337,7 @@ def do_check(self):
# start talking to the server
# do authentication or encryption first
def do_hello(self):
# TODO: maybe change this later to push some more info, not only the
# TODO: maybe change this later to push some more info, not just the
# private IP
message = socket.inet_aton(self.config.get("Global", "clientip"))
self.send(common.CONTROL_CHANNEL_BYTE, common.CONTROL_INIT+message, None)
@@ -101,8 +101,6 @@ def recv(self):
messages = []
message = self.partial_message + self.comms_socket.recv(4096)
if len(message) == len(self.partial_message):
# TODO: check other module if they have this
# 0 length read, socket died
self._stop = True
if len(message) < 2:
@@ -65,7 +65,7 @@ def do_check(self):
# start talking to the server
# do authentication or encryption first
def do_hello(self):
# TODO: maybe change this later to push some more info, not only the
# TODO: maybe change this later to push some more info, not just the
# private IP
message = socket.inet_aton(self.config.get("Global", "clientip"))
self.send(common.CONTROL_CHANNEL_BYTE, common.CONTROL_INIT+message, (self.server_tuple, None))

0 comments on commit 80c3d03

Please sign in to comment.