New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template.add() malfunction? #35

Closed
theopolisme opened this Issue Jun 6, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@theopolisme

theopolisme commented Jun 6, 2013

(link to source where problem occurs)

I'm running a script that adds archiveurl and archivedate parameters to templates (linked above).

When I ran the script for a page that had multiple dead links that needed fixing, this (diff) happened--everything looks fine for the first reference fixed, but in the second one, you'll notice that instead of adding parameters named "archiveurl" and "archivedate", the names of the parameters were the same as their values. This isn't right.

Was my template instance somehow corrupted? Or is there a bug?

@ghost ghost assigned earwig Jun 6, 2013

@earwig

This comment has been minimized.

Show comment
Hide comment
@earwig

earwig Jun 6, 2013

Owner

Strange! I'll have a look.

Owner

earwig commented Jun 6, 2013

Strange! I'll have a look.

@earwig

This comment has been minimized.

Show comment
Hide comment
@earwig

earwig Jun 6, 2013

Owner

@theopolisme - I can't reproduce this. Can you check your current commit? If you're using the pip version, then please clone the repo and switch to develop and install (python setup.py install (or with the --user flag for locally)). Make sure that mwparserfromhell.__version__ is '0.2.dev'. If the bug still happens, let me know.

Owner

earwig commented Jun 6, 2013

@theopolisme - I can't reproduce this. Can you check your current commit? If you're using the pip version, then please clone the repo and switch to develop and install (python setup.py install (or with the --user flag for locally)). Make sure that mwparserfromhell.__version__ is '0.2.dev'. If the bug still happens, let me know.

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jun 6, 2013

Okay, using the develop branch the issue doesn't occur (diff). Guess it might be about time to push a new build to pip. :)

theopolisme commented Jun 6, 2013

Okay, using the develop branch the issue doesn't occur (diff). Guess it might be about time to push a new build to pip. :)

@theopolisme theopolisme closed this Jun 6, 2013

@earwig

This comment has been minimized.

Show comment
Hide comment
@earwig

earwig Jun 7, 2013

Owner

Yeah, I should really get on that. When tags are finished.

Owner

earwig commented Jun 7, 2013

Yeah, I should really get on that. When tags are finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment