Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #26 Use pure python on compilation failure #94

Merged
merged 2 commits into from Jan 12, 2015

Conversation

@jayvdb
Copy link
Contributor

jayvdb commented Jan 12, 2015

Allow the compilation of the extension to fail, and switch
to pure python mode.

Allow the compilation of the extension to fail, and switch
to pure python mode.
@earwig

This comment has been minimized.

Copy link
Owner

earwig commented Jan 12, 2015

This is an excellent idea. Will merge after a review.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2015

Coverage Status

Coverage remained the same when pulling de325a0 on jayvdb:setup-compile-fallback-v040 into d30222e on earwig:develop.

@earwig earwig added this to the version 0.4 milestone Jan 12, 2015
@earwig earwig self-assigned this Jan 12, 2015
@earwig

This comment has been minimized.

Copy link
Owner

earwig commented Jan 12, 2015

@jayvdb I'm a little confused here. If the build fails, why are we saving the extension files as package data? Wouldn't just ignoring them be sufficient?

@jayvdb

This comment has been minimized.

Copy link
Contributor Author

jayvdb commented Jan 12, 2015

This is working, but it is resulting in 'setup.py test' running twice.

@earwig , putting them in package_data means the installed package contains the same source files as the 'mwparserfromhell' directory in the source tree.

@jayvdb

This comment has been minimized.

Copy link
Contributor Author

jayvdb commented Jan 12, 2015

I've nearly got a fix for that; need to travel again. Will upload tomorrow.

@earwig

This comment has been minimized.

Copy link
Owner

earwig commented Jan 12, 2015

But what's the point of keeping the source files around if we couldn't build from them? They're not useful like that, and we don't keep the source files around if the build is successful, anyway. The parser shouldn't have a problem if those files are missing.

'setup.py test' also uses SystemExit, with args[0] as False.
Detect and re-raise.

Add support for building without extension even when compiler
is functional, and set up extension-less travis builds.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2015

Coverage Status

Coverage decreased (-0.32%) when pulling 4e8ce52 on jayvdb:setup-compile-fallback-v040 into d30222e on earwig:develop.

@jayvdb

This comment has been minimized.

Copy link
Contributor Author

jayvdb commented Jan 12, 2015

OK, I've removed the package_data part, and added WITHOUT_EXTENSION builds to travis. The travis builds look like they are doing the right thing, but if you can spot something wrong I'll be happy to fix it.

earwig added a commit that referenced this pull request Jan 12, 2015
Issue #26 Use pure python on compilation failure
@earwig earwig merged commit 07a3d84 into earwig:develop Jan 12, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
earwig added a commit that referenced this pull request Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.