New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"From Version" and "To Version" in Logs #193

Closed
mpsparrow opened this Issue Jul 3, 2017 · 11 comments

Comments

Projects
None yet
2 participants
@mpsparrow
Member

mpsparrow commented Jul 3, 2017

https://wordpress.org/support/topic/feature-request-both-from-version-and-to-version-in-the-update-logs/

If you think about it only one more column would need to be added in order to do this.

@ronalfy

This comment has been minimized.

Member

ronalfy commented Jul 3, 2017

@ronalfy

This comment has been minimized.

Member

ronalfy commented Nov 1, 2017

@mpsparrow in the dev branch, there is logic to allow for this.

I've done my fair share of testing, but if you can help, that would be appreciated.

The way I'm getting the version numbers is a bit whacky as I have to store my own version of plugin/theme assets in a temporary transient.

Translations have no "from" version, so I default to just adding the current version.

@mpsparrow

This comment has been minimized.

Member

mpsparrow commented Nov 2, 2017

@ronalfy Just noticed this now. Will test it in the morning.

@mpsparrow

This comment has been minimized.

Member

mpsparrow commented Nov 2, 2017

Hmm..... so I updated some themes as a test. The version to works great. Version from is the current version as you said. Strangely enough it showed that both the updates failed although the obviously didn't. Let me do a little more testing and see.

@ronalfy

This comment has been minimized.

Member

ronalfy commented Nov 6, 2017

@mpsparrow this may be due to the update transient.

How are you testing? I installed a plugin called Transient Cleaner to clean out any transients.

The develop branch stores a copy of the plugins/themes in a 30 minute transient that way there is a way to compare the previous and updated version.

For my testing, for example, I'd edit a plugin's/theme's heading to be a previous version, clear the transients, then run a manual or automatic update.

This assumes quite a bit, but is the only way I've been able to get the from version to work. The assumption being, that 30 minutes is plenty of time for casual WordPress users and will only affect the testing of logs by us since we're going to be changing things a lot during a 30 minute period.

I hope that makes sense.

@mpsparrow

This comment has been minimized.

Member

mpsparrow commented Nov 6, 2017

@ronalfy makes sense. I will try that and see what the outcome is.

@mpsparrow

This comment has been minimized.

Member

mpsparrow commented Nov 6, 2017

@ronalfy Just tested that and it works flawlessly once I clear the transient.

@ronalfy

This comment has been minimized.

Member

ronalfy commented Nov 6, 2017

@ronalfy

This comment has been minimized.

Member

ronalfy commented Nov 6, 2017

@mpsparrow I'm about ready to deploy this. I feel like I'm playing bug whack-a-mole, and the current status is no bugs, so I'll delay until tomorrow sometime and do some sanity testing on the logs.

@mpsparrow

This comment has been minimized.

Member

mpsparrow commented Nov 6, 2017

@ronalfy I agree. Go ahead whenever you are ready to release it.

@mpsparrow mpsparrow closed this Nov 7, 2017

@ronalfy

This comment has been minimized.

Member

ronalfy commented Nov 7, 2017

I'm happy with my current tests :)

screen shot 2017-11-07 at 11 52 26 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment