Modified @cezum's code to reflect @till's changes for the subform capabi... #26

Merged
merged 1 commit into from Sep 12, 2012

Projects

None yet

3 participants

@four43

...lity.

@till, this is just an update to @cezum's sub form request. I tried my best to add in the changes you asked for. He did all the work, I just made the little tweaks. Let me know if anything else needs tweaking.

(This is my first commit to github, sorry if there is something wrong.)

@four43

This is in response to Issue #20

@till
EasyBib member

These authors should be multiple @author on the class header.

@till
EasyBib member

Hey,

thanks for the effort. Give us a little while to review, we'll try to merge it until early next week!

Till

@till till referenced this pull request Jul 19, 2012
Closed

Decorator to SubForm #20

@four43

No problem. Let me know if you think anything needs fixing. Not sure what the status on @cezum is, but I can try and pick through his code to see if anything needs fixing. Thanks for the initial effort. Glad I can help extend it a little.

@ghost

Hi,

I forgot the checkstyle corrections, sorry. I am using the implementation of subform during 4 months and don't have any problem.

@four43

Nice! I am using it now with no real hiccups. Thanks for the addition!

@till
EasyBib member

Thanks for the feedback, @cezum!

@till till merged commit 6508823 into easybib:master Sep 12, 2012
@till
EasyBib member

Will fix up the rest myself.

@twisty

I think the class in EasyBib/Form/SubForm/Decorator should be named EasyBib_Form_SubForm_Decorator (Instead of EasyBib_Form_SubDecorator)?

@till
EasyBib member

@twisty I think you're right. If you want – send me a PR? I didn't see that when I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment