explicitly check the headers to find out if we already set it #10

Merged
merged 4 commits into from Mar 3, 2014

2 participants

@rwos

Under certain conditions the old check would wrongly report "already set".

@rwos rwos explicitly check the headers to find out if we already set it
Under certain conditions the old check would wrongly report "already
set".
33a8177
@rwos rwos added this to the Current milestone Mar 3, 2014
@yitznewton

@rwos can you write a test case for the "certain conditions?" Also, one of the other tests is broken

@rwos

@yitznewton sure, will do, in a minute - just trying to get the whole package to work first :)

@yitznewton

This all started with commit 9ce42c6 ... We might be able to get away with simply reverting that commit. I believe it was a mistaken solution for a mysterious problem. The goal was to ensure that we never send more than one Authorization header

@rwos rwos self-assigned this Mar 3, 2014
rwos added some commits Mar 3, 2014
@rwos rwos updated test for Auth-Bearer header plugin to actually test the headers aae2935
@rwos rwos added test for Auth-Bearer header plugin
For the case that the same plugin instance is used over multiple
requests.

This used to break at the second request, see
easybiblabs#10
7ff93b3
@rwos rwos deleted unused statement b8ddb81
@rwos

@yitznewton I pushed the tests, ready for review/merge

@rwos

note to self: after merge:

  • PR update to api-client-php
@yitznewton yitznewton merged commit e453b2b into easybiblabs:master Mar 3, 2014

1 check passed

Details default The Travis CI build passed
@yitznewton

Tagged 0.3.1

@rwos rwos deleted the rwos:bugfix/bearer-auth-header branch Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment