Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update siesta easyblock for versions 4.0.1 and 4.1-b3 #1218

Merged
merged 1 commit into from Aug 9, 2017

Conversation

migueldiascosta
Copy link
Member

in the recently released versions,

  • LIBS=, in arch.make, is followed by a newline, which is matched by \s in the regex substitution, resulting in a broken line
  • two utils are cleaned after being built, resulting in failed sanity checks

this fixes both issues, will submit corresponding easyconfigs

@akesandgren please review?

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@boegel boegel added this to the 3.4.0 milestone Aug 9, 2017
@boegel
Copy link
Member

boegel commented Aug 9, 2017

Tested both with existing Siesta easyconfigs and easybuilders/easybuild-easyconfigs#4888, going in, thanks @migueldiascosta!

@boegel boegel merged commit aea088a into easybuilders:develop Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants