Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default java encoding to utf8 for Trinity #1302

Merged
merged 2 commits into from Dec 6, 2017

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Dec 4, 2017

This is needed to avoid compilation failure due to non-standard characters in java comments (see the Butterfly module).

@@ -72,6 +73,8 @@ def butterfly(self):

self.log.info("Begin Butterfly")

setvar("-Dfile.encoding", "UTF8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong to me...

setvar is for defining environment variables, you are defining $-Dfile.encoding to UTF8 here, which is not what you want to do I'm guessing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops..

@boegel boegel added this to the 3.5.0 milestone Dec 5, 2017
@boegel
Copy link
Member

boegel commented Dec 6, 2017

Tested with existing Trinity easyconfigs, lgtm, so going in, thanks @smoors!

@boegel boegel merged commit 0f5d986 into easybuilders:develop Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants